12 replies to this topic

[emes30]

I found two bugs in the scripts:

1. PreConfig - detecting WAIK assumes that it is installed in "C:\Program Files" not using value provided in options
2. Common_API - detecting SP level also has problems with WAIK, directory name is mistyped under SP0 resulting Unsupported SP

[JonF]

Thanks, I will look tomorrow. Today I'm sick.

[dera]

I think the problem is only that
in the script
'\Base\01-preconfig.script' Version=16
at line #73
[codebox] If,ExistDir,"%BootSRC%\Windows\System32\DriverStore\FileRepository\[b]1394.inf_1394.inf[/b]_1c635995",IniWrite,%ProjectInfo%,"VistaInfo","SourceSPLevel",0 [/codebox]there is a typo: 1394.inf_1394.inf_1c635995 instead of: 1394.inf_1c635995 at me when AIK for Vista SP0 installed to 'C:\SP0 AIK', and if i defined this path as 'Source directory (%SourceDir%)' in the 'Source' tab - as i want to use the AIK's winpe.wim as source, and also defined this path in the FileBox in 'Base\Preconfig' - as imagex.exe resides here,
then the path to imagex.exe and also the path to the winpe.wim are detected correctly,
winpe.wim mounted successfully into %BootSRC%

[emes30]

In my case the problem is in file 01-preconfig at line #193
in section Find-WAIK

If,ExistFile,"%ProgramFilesDir%\Windows#$sAIK\Tools\PETools\x86\winpe.wim",Begin

Set,"%SDIR%","%ProgramFilesDir%\Windows#$sAIK\Tools\PETools\x86"

it should be

If,ExistFile,"%pFileBox1%\Tools\PETools\x86\winpe.wim",Begin

Set,"%SDIR%","%pFileBox1%\Tools\PETools\x86"

I think that Source directory should point to Vista DVD and should not be used during WAIK only buid.

[dera]

but '01-preconfig.script'
first check:

If,ExistFile,"%SourceDir%\sources\boot.wim",Begin

  Set,%SDIR%,"%SourceDir%"

  Set,%VISTACD%,"OK"

  Echo,"Vista DVD found [%SDIR%]"

End

%SourceDir% is that path what is defined
in the FileBox 'Source directory (%SourceDir%)' in the 'Source' tab

and if %VISTACD% = OK then the section [Find-WAIK] is not processed

at least at me when
in the FileBox 'Source directory (%SourceDir%)' in the 'Source' tab
i define the path to the DVD root
then boot.wim and install.wim from the DVD's 'sources' folder are mounted
and not the winpe.wim form the installed AIK folder

[emes30]

I don't have Vista DVD. I use WAIK only, so Find-WAIK section is processed.

Another problem:
My Norton Antivirus complains about:
MapNetworkDrive.exe W32.SillyFDC found
produkey.exe don't know why

NAV has to be disabled during image building.

[dera]

sorry,
i do not understand the problem exactly

ok
if %SourceDir%\sources\boot.wim not found
then
the [Find-WAIK] section is processed

at me - as i wrote in post #3
in that case if 'C:\SP0 AIK' (i installed the AIK into this folder)
typed into the Filebox 'Source directory (%SourceDir%)' in the 'Source' tab
then the path to the winpe.wim is detected correctly,
and the winpe.wim of the installed AIK is mounted successfully

[JonF]

I don't have Vista DVD. I use WAIK only, so Find-WAIK section is processed.

Can you post a log? (ZIP it up first).

If you have entered the correct path to the the WAIK on the Source tab in Winbuilder, then one of the tests in [Find-WAIK] should succeed. I don't know why NightMan put the generic one first, but it should not matter in which order the tests are carried out.

You could argue that for a WAIK-only build then %SourceDir% should not be used, but you could also argue otherwise, and it's done otherwise now. I wouldn't change it unless we determine there actually is a problem.

Another problem:
My Norton Antivirus complains about:
MapNetworkDrive.exe W32.SillyFDC found
produkey.exe don't know why

NAV has to be disabled during image building.

I've seen Avira complain about MapNetworkDrive.exe. It's a false positive - I don't know how to fix it other than turning off AV.

@dera: Yes, another typo. Damn. I will wait until this issue is resloved before uploading the correction.

[emes30]

If you have entered the correct path to the the WAIK on the Source tab in Winbuilder, then one of the tests in [Find-WAIK] should succeed. I don't know why NightMan put the generic one first, but it should not matter in which order the tests are carried out.

You could argue that for a WAIK-only build then %SourceDir% should not be used, but you could also argue otherwise, and it's done otherwise now. I wouldn't change it unless we determine there actually is a problem.

It works if Source points to WAIK installation.

But you force script user to enter same path twice, for me it wasn't clear and I modified the script.
Generic test is bad solution anyway, it ignores what user has entered in WAIK Source box,
and it confused me when I saw in log generic path instead of what I entered.

[dera]

The VistaPE project originally is not Jonf's project,
the original project and design came from NightMan,
here is the original project: http://vistape.net/
but seems NightMan disappeared from this forum

nevertheless in also every other WinBuilder based projects the 'Source' tab used to define that path
"from where your files will be copied"

Edit:
i guess the 'Source' tab is not project dependent
but a feature of itself the WinBuilder.exe
and the path what you entered on the 'Source' tab always will be the variable: %SourceDir% what is a built-in variable of the WinBuilder.exe

maybe it is not clear enough at the first time
but the path what you entered in the 'Base\Preconfig' script's filebox
is used only to define the variable %IMAGEX% = the full path to imagex.exe
(and for nothing else, see section [AutoFindImagex] and search for %pFileBox1% in this 01-preconfig.script),
i think this path doesn't ignore the %SourceDir% - as maybe someone will use an install DVD as source
nor the %SourceDir% doesn't ignore this path - as the installed AIK (exactly WimFltr and imagex.exe) is mandatory to build and maybe someone will install the AIK not into its default location: 'C:\Program Files\Windows AIK'

so maybe the design is wrong, but still don't understand exactly where is the bug? (besides the typo: 1394.inf_1394.inf_1c635995)

Edited by dera, 31 August 2009 - 12:47 PM.

[paraglider]

I always find the source tab confusing. Cannot count the number of times I have clicked it expecting to find the current script source.

[WetHat]

I found two bugs in the scripts:

1. PreConfig - detecting WAIK assumes that it is installed in "C:\Program Files" not using value provided in options
2. Common_API - detecting SP level also has problems with WAIK, directory name is mistyped under SP0 resulting Unsupported SP

I think I found another bug in the 06-custom-folder.script. When the target custom folder does not exist (which is usually the case when rebuild the entire script), DirCopy fails.

[process]

RunFromRAM,False

If,ExistDir,"%pFileBox1%",Begin

  DirCopy,%pFileBox1%\*.*,%TargetDir%\%pTextBox2%

...

should be instead

[process]

RunFromRAM,False

If,ExistDir,"%pFileBox1%",Begin

  DirMake,"%TargetDir%\%pTextBox2%"

  DirCopy,%pFileBox1%\*.*,%TargetDir%\%pTextBox2%

  ...

I have attached a fixed version of the script

WetHat

Attached Files

•  06_custom_folder.zip   2.27K   127 downloads

[JonF]

You're right.