242 replies to this topic

[pscEx]

--------------------------------------------------------------
Service Note (Lancelot):
Topic closed, "WinBuilder 078 SP7 scheduled for upload" topic ended with 080 release. Goal of this topic ended, No need current topic anymore.
Topic name changed to "WinBuilder 080 scheduled for upload" for a better representation.
Topic can be used to point previous discussed issues easly. (also approved by psc)
--------------------------------------------------------------
@All, especially @Lancelot

Before I publish, please test whether it can become the 'official' usable version.

I want to replace the 077RC2 for LiveXP finally.

The actual SP7 can be found in the trash (see here: REMOVED (Lancelot))

Peter

BTW @Lancelot: There is a new command If,EXISTMACRO

EDIT: Added actual history
[080]
date=2010-01-15

fixed - Bug ID #238: new scripts added to server not seen on download list
fixed - bug: command line 'If, ... ,If, ... ,Begin' causes double indent in log.html
fixed - bug: Some RegWrite errors have been logged as successfully processed
changed - RegWrite 0x1 tolerates syntax error (comma in string rather than escape)
added - If,EXISTMACRO command
added - Error when StrFormat calculates with uninitialized variables (gave accesss violation right now)
changed - Make GUI in Download Center simpler mit respect to 'Dummy User'
added - detection of Win7 to %HostOS%
changed - Set command: replace comma and space by escapes
added - AddInterface can optionally define an alternate interface
fixed - bug in RegRead multi_sz
added - StrFormat,CTRIM and StrFormat,SPLIT now can have escapes as 'single character'
added - Variable %WBExe%
fixed - bug in DirDelete,FAST left temp files in root
fixed - bug in download center: On first show tree was allways built, regardless of 'green arrow' definition

[Lancelot]

Just noticed the topic,
and just downloaded new trash.

I will make wildest tests and checks I know tomorrow,

meanwhile, If you change trash, please post info here to avoid mismatches.

[pscEx]

During you replied, I added history to first post.
So in the history you can allways see whether something changed.

Peter

[Galapo]

Hi Peter,

Can you tell me what 'If,EXISTMACRO' does?

Thanks,
Galapo.

[Lancelot]

Hi Galapo,

check here http://www.boot-land...amp;showbug=242

[Galapo]

Thanks, Lancelot. I now understand the difference between variables and macros: variables can never "execute", they just expand content, whereas macros execute. Previously, variables could also execute, but this functionality has been split to new macros.

Hence I think we need a new command: SetMacro. To me it seems there is little advantage in having the difference between a variable and a macro determined by using % or not. So:

Set,%var%,test would set a variable
SetMacro,%macro%,"Run,%ScriptFile%,test" or SetMacro,%macro%,Run#$c%ScriptFile%#$ctest would set a macro.

WB would then have two separate stacks, variables and macros. A variable could be turned into a macro:

[variables]

%var%=Run,%ScriptFile%,test



[process]

SetMacro,%macro%,%var%

%macro%,yes!



[test]

Echo,#1

This leads me to suggest that if WB splits variables and macros at the stack level, then logically it also needs to split this at script level. That is, we can't have macros under [variables]. Macros need to be listed under a new [macros] section. Eg:

[variables]

%section%=1



[macros]

test=run,%scriptfile%,%section%



[process]

test,yes!



[1]

Echo,#1

What do you think?

Regards,
Galapo.

[pscEx]

Thanks, Lancelot. I now understand the difference between variables and macros: variables can never "execute", they just expand content, whereas macros execute. Previously, variables could also execute, but this functionality has been split to new macros.

Hence I think we need a new command: SetMacro. To me it seems there is little advantage in having the difference between a variable and a macro determined by using % or not. So:

Set,%var%,test would set a variable
SetMacro,%macro%,"Run,%ScriptFile%,test" or SetMacro,%macro%,Run#$c%ScriptFile%#$ctest would set a macro.

WB would then have two separate stacks, variables and macros. A variable could be turned into a macro:

[variables]

   %var%=Run,%ScriptFile%,test

   

   [process]

   SetMacro,%macro%,%var%

   %macro%,yes!

   

   [test]

   Echo,#1

This leads me to suggest that if WB splits variables and macros at the stack level, then logically it also needs to split this at script level. That is, we can't have macros under [variables]. Macros need to be listed under a new [macros] section. Eg:

[variables]

   %section%=1

   

   [macros]

   test=run,%scriptfile%,%section%

   

   [process]

   test,yes!

   

   [1]

   Echo,#1

What do you think?

Regards,
Galapo.

I think it is not reasonable to add this functionality right now.
It cannot be done with some lines of code (like it has been possible with if,EXISTMACRO..

Since a long time the 'macro' handling should be known:

I think that cannot.

Reason: formally text defined in [Variables] replaced this text, whenever it appeared inside a line.

That lead to several bug reports.

Therefore starting with 075 's new variables handling [Variables] without the % are only replaced when they are the first element in a script line. Then they mean some shortcuts to other commands (like used in the API) and are called 'macros'

Peter

Implicitelly this says that a macro can only be defined in the [variables] section.
When resolving the [variables] section, WinBuilder looks for the % and decides whether to put into the varables or macros list.

So let's consider as a request for a future version.

Peter

EDIT: Try this code:

[variables]

 test=run,%scriptfile%,%section%

 %section%=1

 

 [process]

 test,yes!

 Set,%section%,2

 test,great!

 

 [1]

 Echo,ONE:#1

 

 [2]

 Echo,TWO:#1

[pscEx]

New version uploaded to trash:

Following Nuno's suggestion, in the Download Center GUI now the red 'stop' square and the green 'go' arrow are invisible for the standard user.

They can be individually activated in the 'Options' tab of the download center.

Peter

[Lancelot]

Hi Peter,

I just could find time to make tests,
after checking default builds (which did not throw error or warnings (I feel Nuno has role on that) ) I start to check bug reports.

*
Time will show download mechanism works as expected, since it is flagged as fixed I assume all download mechanism works nicely.

***
BUG-ID 240 still does not exists, This should be the MOSSSTTTT (TOP 1) (Critical) (Essential) important "fix or enhancement" of wb078sp7 ???????????


Episode1 - 0x1
Galapo's example 1 do not throw error

Set,%DisplayNameForWBSoftware%,"test4,5"

RegHiveLoad,WB-Software,%target_sys%\config\software

RegWrite,HKLM,0x1,WB-Software\PSC,DisplayName,%DisplayNameForWBSoftware%

RegHiveUnLoad,WB-Software

also this do not throw error too.

RegHiveLoad,WB-Software,%target_sys%\config\software

RegWrite,HKLM,0x1,WB-Software\PSC,DisplayName0000,a,b

RegHiveUnLoad,WB-Software

I need clearance (confirmation) about RegWrite 0x1.
As far as i understand, since 0x1 can add only 1 value, than all values after 5th comma whether between quotes or not, are used as a single value by winbuilder ?????
If this is the case, I am fine with it
If this is not, than what is it ????




Episode2 - 0x7
Mooooooost important,
Galapo's example 4 do not add 1 entry but 2 !!

Set,%DisplayNameForWBSoftware%,"test4,5"

RegHiveLoad,WB-Software,%target_sys%\config\software

RegWrite,HKLM,0x7,WB-Software\PSC,DisplayName7,%DisplayNameForWBSoftware%

RegHiveUnLoad,WB-Software

Set,%DisplayNameForWBSoftware%,"test4,5"

RegHiveLoad,WB-Software,%target_sys%\config\software

RegWrite,HKLM,0x7,WB-Software\PSC,DisplayName7q,"%DisplayNameForWBSoftware%"

RegHiveUnLoad,WB-Software

with other words, value data should be different. DisplayName7 is correct, DisplayName7q is NOT.

Giving one more example following Galapo's examples

RegHiveLoad,WB-Software,%target_sys%\config\software

Set,%DisplayNameForWBSoftware%,"test4,5"

Set,%DisplayNameForWBSoftware2%,"test6,7"

Echo,"Writing 2 values for 0x7"

RegWrite,HKLM,0x7,WB-Software\PSC,DisplayName7t2,"%DisplayNameForWBSoftware%","%DisplayNameForWBSoftware2%"

Echo,"Writing 3 values for 0x7 (a)"

RegWrite,HKLM,0x7,WB-Software\PSC,DisplayName7t3a,%DisplayNameForWBSoftware%,"%DisplayNameForWBSoftware2%"

Echo,"Writing 3 values for 0x7 (b)"

RegWrite,HKLM,0x7,WB-Software\PSC,DisplayName7t3b,"%DisplayNameForWBSoftware%",%DisplayNameForWBSoftware2%

Echo,"Writing 4 values for 0x7"

RegWrite,HKLM,0x7,WB-Software\PSC,DisplayName7t4,%DisplayNameForWBSoftware%,%DisplayNameForWBSoftware2%

RegHiveUnLoad,WB-Software

I hope clear.

This is Most Important, because this enhancement will end the confusions and misusages for these situations which cause lots of disturbance for a looooooooooong while.
(So I can fix scripts that uses none logable workarounds to avoid these situations, but now i can not ?!?!?!) Since it was already confirmed than where is it ??????
and if we need to delay a week to get this on sp7, than I am happy to wait a week (or more).

[pscEx]

Try the new trash.
But do not worry about the version number. I agreed with Nuno, that the current 078 SP7 becomes the stable 080 when the experts agree that it is practically error free.

Let me quote a post of mine which is still valid.

In the last days with rather complicated variables the question came up that WinBuilder's variables handling sometimes fails.

Here a short explanation what can be done and what cannot be done.

First some rules:

• WinBuilder Script Line Parameters are separated by a comma.
  If a comma is inside an argument, it must be 'escaped' by #$c
• Besides some special cases (e.g. parameters in ShellExecute) generally enclosing quotes are not needed.
• Enclosing quotes MUST be used if the WinBuilder Script Line Parameters contain spaces
  If the spaces are replaced by the escape #$s, the enclosing quotes should be ommitted.

In most cases user violation of that rules are accepted by WinBuilder and processed as assumed.
E.g. unnecessary enclosing quotes or a comma inside an item enclosed by quotes.

But sometimes that can bring unexpected results.

To

As far as i understand, since 0x1 can add only 1 value, than all values after 5th comma whether between quotes or not, are used as a single value by winbuilder ?????

If you use WinBuilder with the option "Check Parameter Count" (ALL developers should do that!) you'll see a warning about invalid syntax.

Never trust that invalid syntax will interpreted in the same way in different WinBuilder versions!

The above quote also explains that in the 0x7 sample the unnecessary quote will not cause different interpretation.

Peter

[pscEx]

New version uploaded:

added - AddInterface can optionally define an alternate interface

Peter

[pscEx]

New version uploaded:

fixed - bug in RegRead multi_sz

That hopefully is the final solution alternity to Lancelot's Episode 2

To explain for others:
Try this in codebox:

[process]

// test for adding multi_sz reg keys containing commas and spaces

RegHiveLoad,WB-Software,%target_sys%\config\software

//Init the multi_sz key

RegWrite,HKLM,0x7,WB-Software\PSC,myTest,"First , A"

//Add value

RegRead,HKLM,WB-Software\PSC,myTest,%var%

RegWrite,HKLM,0x7,WB-Software\PSC,myTest,%var%,"Second , B"

//Add value

RegRead,HKLM,WB-Software\PSC,myTest,%var%

RegWrite,HKLM,0x7,WB-Software\PSC,myTest,%var%,"Third , C"

RegHiveUnLoad,WB-Software

Peter

[Lancelot]

with newest trash here is my summarize:

*
0x1 above my fault, I now learned enableing "Check Parameter Count" all the time. Everything okey with 0x1 with the way Galapo requested.

*
Galapo's request for 0x7 changed, changes are good to me.

Now more definete rules says,

+
as shown previous post of psc, now we can easly regread 0x7 to a variable %var7% and add new string(s) to the begining or end.

+
If you do not use regread, than you can NOT add multistring value with single variable without using escape charecters, you need to define each one seperately.
Edit1: To add multistring value with single variable, you have to use #$z , check here

as a result, following example of Galapo:

Set,%DisplayNameForWBSoftware%,"test4,5"

RegHiveLoad,WB-Software,%target_sys%\config\software

RegWrite,HKLM,0x7,WB-Software\PSC,DisplayName,%DisplayNameForWBSoftware%

RegHiveUnLoad,WB-Software

Set,%DisplayNameForWBSoftware%,"test4,5"

RegHiveLoad,WB-Software,%target_sys%\config\software

RegWrite,HKLM,0x7,WB-Software\PSC,DisplayName,"%DisplayNameForWBSoftware%"

RegHiveUnLoad,WB-Software

both will result single test4,5 value and both are correct (and since psc do not like quotes, first is more correct , and no quotes (test4#$c5) is most )

ps: my previous examples with DisplayName7t2 - DisplayName7t3a - DisplayName7t3b - DisplayName7t4 will always write 2 sub values too and all are correct .

+
In order to finish examples, writing multi values without regread and using variables, following works:

Set,%DisplayNameForWBSoftware1%,"test4,5"

Set,%DisplayNameForWBSoftware2%,"test6,7"

Set,%DisplayNameForWBSoftware3%,"test8,9"

RegHiveLoad,WB-Software,%target_sys%\config\software

RegWrite,HKLM,0x7,WB-Software\PSC,DisplayName,%DisplayNameForWBSoftware1%,%DisplayNameForWBSoftware2%,%DisplayNameForWBSoftware2%

RegHiveUnLoad,WB-Software

+
adding a new value inbetween a multi-string value: Will be available with next trash (currently not available) and with an optimized wb code psc provide (hopefully next post tomorrow).
ps: This is a verrrrrrrry rare thing that maybe requested. I agree with Peter not to use a new syntax, better to use available syntax. Final decisions will be made by psc tomorrow.
Edit2: I believe this can be posponed as a future request to ease release of stable release, final decision is yours psc.



********
In the end (after 4 recent boxing matches about current these things ), I truely believe this 0x7 & Variable annoyance coming to the end for next wb after lots of months. These new definate rules are good for me If I miss something ???? please comment.

Today was a very productive day for next wb, Tomorrow night, other tests .


Edit1: Fixed
Edit2: Adding.

[Lancelot]

Minor Things:
(a bit long to write, but they are verrry tiny )

**
"Extract To Desktop" does not work as intented.
Reason:
I guess wb extracts to %userprofile%\Desktop
BUT
my desktop is at
D:\Documents and Settings\Administrator\Desktop

Reason Behind:
Windows universally stores Desktop information at registry and many users including me change this location.

[HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\User Shell Folders]
"Desktop"="D:\\Documents and Settings\\Administrator\\Desktop"

wb should read 0x1 or 0x2 values from there.
ps: Keep in mind, it could be also elsewhere with other user settings with reg_expand_sz with something like %USERPROFILE%\DesktopNewFolder

**
at download section, there is a default enabled checkbox:
"Rebuild download tree only on on green arrow click (makes green arrow visible)"
1) typo: on on
2) enableing checkbox does not work as expected. Here is the story:
-select livexp server, enable this checkbox, close winbuilder.
-when I freshly start winbuilder, and click download, download section automaticallly downloads info from livexp server (since it is selected from previous session) and builds download tree. (I did NOT click green button to do that )

-What I expect is, after clicking download, select (or change) server, than click this green button.

Reason behind: Now we can download and use multiple projects with single winbuilder.

Story1:
For all stories, assume an experienced user enabled the checkbox knowing what it does.

Story1a:
Lets say I downloaded LiveXP, than now time to download (or check) nativeex_barabone server,
Being an advanced user I already enabled this checkbox (which is default disabled), but because of this unexpected behaviour I have to wait wb to download info from livexp server and build tree first. Than I change server to nativeex, than I hit green button again.

Story1b:
Imagine 3 server selected initially to download 3 projects, after a while I decide to download 4th project, but when I click download (and my green button checkbox selected) I have to wait wb first download these 3 project infos and build tree (lots of time).

I hope understood.

[Galapo]

as shown previous post of psc, now we can easly regread 0x7 to a variable %var7% and add new string(s) to the begining or end.

Excellent work, Peter! I can now do the following:

System,ERROROFF,5

RegHiveLoad,WB-Software,%target_sys%\config\software

RegWrite,HKLM,0x7,WB-Software\PSC,DisplayName,test4,5

RegRead,HKLM,WB-Software\PSC,DisplayName,%DisplayNameForWBSoftware%

RegWrite,HKLM,0x7,WB-Software\PSC,DisplayName,%DisplayNameForWBSoftware%,6

RegHiveUnLoad,WB-Software

Thanks,
Galapo.

[Lancelot]

something noticed:

1)
escape in escape does not work
check this

Set,%DisplayNameForWBSoftware1%,"test4,5"

Set,%DisplayNameForWBSoftware2%,"test6,7"

Set,%DisplayNameForWBSoftware3%,"test8,9"

Set,%DisplayNameForWBSoftware4%,"##$c"

Set,%DisplayNameForWBSoftware5%,"##$z"

RegHiveLoad,WB-Software,%target_sys%\config\software

RegWrite,HKLM,0x7,WB-Software\PSC,DisplayName,--

RegWrite,HKLM,0x7,WB-Software\PSC,DisplayName,%DisplayNameForWBSoftware1%,%DisplayNameForWBSoftware2%,%DisplayNameForWBSoftware3%,%DisplayNameForWBSoftware4%,%DisplayNameForWBSoftware5%

RegRead,HKLM,WB-Software\PSC,DisplayName,%var%

Echo,%var%

Message,%var%

RegHiveUnLoad,WB-Software

2)
reading key (regread) including escape charecters does not work.

ps: I guess this was the thing fxscrpt asked at last times of his existance, I am not sure. My mind hardly tells me there was also a topic introducing a workaround .... can you point me ?

Maybe I miss something.
If so sorry.
If not, for now I believe this can be posponed to next version (I do not know something using that).

ps: I will not be around tomorrow, so I put things when I notice here

[Galapo]

Is it possible to implement this from the bugtracker. Maybe it will solve our 0x7 issues?

http://www.boot-land...amp;showbug=129

Regards,
Galapo.

[Galapo]

This works as expected, too:

System,ERROROFF

Set,%DisplayNameForWBSoftware%,"test4#$x5"

RegHiveLoad,WB-Software,%target_sys%\config\software

RegWrite,HKLM,0x7,WB-Software\PSC,DisplayName,%DisplayNameForWBSoftware%

RegHiveUnLoad,WB-Software

Regards,
Galapo.

[Galapo]

Hi Peter,

Also, is it possible to implement this for 080 also? (Assuming it's not too difficult.)

http://www.boot-land...amp;showbug=224

Thanks,
Galapo.

[pscEx]

Hi Peter,

Also, is it possible to implement this for 080 also? (Assuming it's not too difficult.)

http://www.boot-land...amp;showbug=224

Thanks,
Galapo.

Done!

new trash uploaded:

added - StrFormat,CTRIM and StrFormat,SPLIT now can have escapes as 'single character'
added - Variable %WBExe%
fixed - bug in DirDelete,FAST left temp files in root

Peter

[pscEx]

New version uploaded

fixed - bug in download center: On first show tree was allways built, regardless of 'green arrow' definition

Peter

[pscEx]

Actually sad, thought the good thing about wb is it flexibility ...

To proof the flexibility of WinBuilder (and that one of mine ):

New version in trash

added - RegAddMulti command

RegAddMulti,HKLM,Section,Key,APPEND,String

   RegAddMulti,HKLM,Section,Key,PREPEND,String

   RegAddMulti,HKLM,Section,Key,BEFORE,SubVal,String

   RegAddMulti,HKLM,Section,Key,BEHIND,SubVal,String

   RegAddMulti,HKLM,Section,Key,PLACE,Index,String

   RegAddMulti,HKLM,Section,Key,DELETE,SubVal

I'm sure that makes time consuming external autoit apps obsolete.
@JFX: Be as flexible as the WB team and replace your autoit stuff in the same time of less than 2 hours!

Peter

EDIT:
Small logical addition and new upload:
When the BEFORE item does not exist, the new item is inserted as first one.
When the BEHIND item does not exist, the new item is appended.
In both cases there is a warning in the log.
(The previous version could crash in those cases)

[was_JFX]

Works very like a charm

Just a minor thing:

BEFORE and BEHIND make it possible to put a string more the once in a MULTI_SZ.

[pscEx]

BEFORE and BEHIND make it possible to put a string more the once in a MULTI_SZ.

Thanks! I'll prohibit that (tomorrow)
BTW: I think that all methods make it possible, because currently I do not check the presence of the string before write.

Peter

[Lancelot]

@JFX

Please test with adding experimental escape strings to 0x7 registry, have fun.
example: prepare a 0x7 value with something like
string1=#$ctest1
string2=#$ztest2

I hope it works.....


@psc
I do not like the current solution (which we agreed to pospone for next version ;) ), it seems to me causing more troubles in future. anyway it is your decision.....

Here is a bug I guess

prepare 1.txt at C:\1.txt

[main]

value1=#$c#$ztest1

value2=test2

try following

Set,%variable1%,--

Set,%variable2%,--

IniRead,C:\1.txt,main,value1,%variable1%

IniRead,C:\1.txt,main,value2,%variable2%

RegHiveLoad,WB-Software,%target_sys%\config\software

RegWrite,HKLM,0x7,WB-Software\11,IniReadTest,%variable1%,%variable2%

RegHiveUnLoad,WB-Software

what should I do to fix ???

Edit: wb code fix